fix: use 'e2e' label trigger for secure secrets access#79
Merged
gh-simili-bot merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
Switch from `pull_request_review` to `pull_request_target` (types: labeled). The review event on forked PRs does not grant access to secrets, causing E2E failures. Using `pull_request_target` filters by the 'e2e' label ensures: 1. Access to secrets (secure context). 2. Manual approval gate (maintainer adds label). 3. Explicit checkout of PR code via ref logic. Signed-off-by: Kavirubc <hapuarachchikaviru@gmail.com>
gh-simili-bot
approved these changes
Feb 18, 2026
Contributor
Simili Triage ReportNote Quality Score: 9.5/10 (Excellent) Classification
Quality Improvements
Similar Threads
Warning Possible Duplicate (Confidence: 95%) Generated by Simili Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The previous fix used
pull_request_reviewto trigger E2E tests. However, workflows triggered by reviews on forked PRs do not have access to secrets, regardless of approval status. This caused the E2E workflow to fail immediately.Solution
Switch trigger to
pull_request_target(types:labeled).e2elabel is added.e2elabel to run the test.Checks out PR code securely via explicit
reflogic.