fix:ui: Display All Transactions correctly [#2476]#2550
Open
TuongNM wants to merge 1 commit intosimonmichael:masterfrom
Open
fix:ui: Display All Transactions correctly [#2476]#2550TuongNM wants to merge 1 commit intosimonmichael:masterfrom
TuongNM wants to merge 1 commit intosimonmichael:masterfrom
Conversation
Even if there there are no displayitems left, there are still blankitems in the List. With this the List is not technically empty and will therefore keep showing a selection. This is fixed by actively removing the list selection if there are no displayitems left. Also, if there are only blankitems left, the colwidths cacluation in the RegisterScreen produces negative widths. The fitText function would then see that the 0-length of the blankitems is greater than the negative widths and ellipsify. This is fixed in the RegisterScreen by ensuring that no negative widths are passed and more generally in the fitText function by treating negative max widths as 0.
Contributor
Author
|
Technically, it's only necessary to either not pass negative widths in the RegisterScreen or have fitText treat negative max widths as 0. Both instances seemed unintended to me so I adjusted them both. But if there is a reason I'm unaware of where one of these behaviors needs to be kept as is, it would be possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if there there are no displayitems left, there are still blankitems in the List. With this the List is not technically empty and will therefore keep showing a selection.
This is fixed by actively removing the list selection if there are no displayitems left.
Also, if there are only blankitems left, the colwidths cacluation in the RegisterScreen produces negative widths. The fitText function would then see that the 0-length of the blankitems is greater than the negative widths and ellipsify.
This is fixed in the RegisterScreen by ensuring that no negative widths are passed and more generally in the fitText function by treating negative max widths as 0.
Fixes #2476