Skip to content

Avoid allocating in pre_exec closure#351

Open
sylfn wants to merge 2 commits intosimonrw:mainfrom
sylfn:pre_exec
Open

Avoid allocating in pre_exec closure#351
sylfn wants to merge 2 commits intosimonrw:mainfrom
sylfn:pre_exec

Conversation

@sylfn
Copy link

@sylfn sylfn commented Nov 21, 2025

Error::new allocates memory (see rust-lang/rust#148971). This is bad in multi-threaded programs, which dap-gui AFAIK is. If the fork occurs while the allocator lock is held by another thread, deadlocks can occur, since there's no one left in the new process to unlock the mutex. I do not believe this is UB, and modern libc offer protections against this issue, but this isn't POSIX-compliant and should preferably be avoided.

nix provides a non-allocating impl From<Errno> for std::io::Error, which can be used instead. This doesn't allow an additional message to be added, but since error messages aren't transmitted across pre_exec boundary anyway, this doesn't make visible behavior any worse. On the flip side, this ensures that the correct error code is forwarded to the parent process, instead of the default -EINVAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant