Don't initialize uinput unless it's necessary
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm only using `cecdaemon` to run commands, not to send keypresses via `uinput`. I'd like to avoid initializing `uinput` because it's a bit tricky to set up: 1. It requires the user I'm running `cecdaemon` under to permissions it doesn't currently have. 2. It requires my system to have loaded the `uinput` kernel module, which doesn't actually happen on my device. See pyinput/python-uinput#9 (comment) for more details. While I could fix both of these issues, this is such a minor change to `cecdaemon`, I thought it would be an acceptable change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm only using
cecdaemonto run commands, not to send keypresses viauinput. I'd like to avoid initializinguinputbecause it's a bit tricky to set up:cecdaemonunder to permissions it doesn't currently have.uinputkernel module, which doesn't actually happen on my device. See PermissionError: [Errno 13] Failed to open the uinput device: Permission denied pyinput/python-uinput#9 (comment) for more details.While I could fix both of these issues, this is such a minor change to
cecdaemon, I thought it would be an acceptable change.