Edit the command with prompt_toolkit instead of readline#4
Merged
simonw merged 1 commit intosimonw:mainfrom Mar 26, 2024
Merged
Edit the command with prompt_toolkit instead of readline#4simonw merged 1 commit intosimonw:mainfrom
simonw merged 1 commit intosimonw:mainfrom
Conversation
The readline on some Python versions is based on libedit, which doesn't support either set_startup_hook or insert_text - it just sits there waiting for input. IPython uses prompt_toolkit for editing, which feels like a more modern solution. It can even highlight the shell command using Pygment's BashLexer.
Owner
Owner
|
https://pypi.org/project/prompt-toolkit/ looks like a clean new dependency - BSD licensed, widely used. Actively maintained on https://github.com/prompt-toolkit/python-prompt-toolkit for 10+ years, and good documentation: https://python-prompt-toolkit.readthedocs.io/en/stable/ Plus it doesn't pull in many other dependencies - installing in a fresh environment only pulls it plus one other: |
Owner
|
I'm going to land this as-is and then decide what to do with |
Contributor
Author
|
Suggestion for pygments handling in #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The readline on some Python versions is based on libedit, which doesn't support either set_startup_hook or insert_text - it just sits there waiting for input. IPython uses prompt_toolkit for editing, which feels like a more modern solution. It can even highlight the shell command using Pygment's BashLexer.
Fixes #3