Skip to content

Catch runtime exceptions from --code, not just SyntaxError #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikatyal2110 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

Catch runtime exceptions from --code, not just SyntaxError #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlite_utils/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3800,7 +3800,7 @@ def _rows_from_code(code):
namespace = {}
try:
exec(code, namespace)
except SyntaxError as ex:
except Exception as ex:
raise click.ClickException("Error in --code: {}".format(ex))
rows = namespace.get("rows")
if callable(rows):
Expand Down
11 changes: 11 additions & 0 deletions tests/test_cli_insert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,6 +880,17 @@ def test_insert_code_syntax_error(tmpdir):
assert "Error in --code" in result.output


def test_insert_code_runtime_error(tmpdir):
db_path = str(tmpdir / "dogs.db")
result = CliRunner().invoke(
cli.cli,
["insert", db_path, "creatures", "--code", 'raise ValueError("bad data")'],
)
assert result.exit_code == 1
assert "Error in --code" in result.output
assert "bad data" in result.output


def test_insert_code_file_not_found(tmpdir):
db_path = str(tmpdir / "dogs.db")
result = CliRunner().invoke(
Expand Down
Loading