Sync simplecast rust device detector to main upstream matomo library#15
Merged
Conversation
Copies the latest Tests/Parser/fixtures/oss.yml from PHP device-detector, adding short_name fields (ignored by Rust tests) and one new test case for iPadOS 19.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…roup syntax Replaces the previously hand-expanded individual Darwin version entries (Darwin/25.4.0, Darwin/25.3.0, ...) with PHP's compact capture group form (Darwin/25\.([0-4])\.0 => 26.$1). Functionally identical since the Rust parser uses fancy_regex captures.expand which supports $1 substitution. This makes regexes/oss.yml byte-for-byte identical to the PHP upstream so copy_static_files.sh produces no diff. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update regexes/oss.yml and tests/data/fixtures/parser/oss.yml to match matomo php library