Skip to content

Optimize MongoDB SCIM query by applying filters before joins #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Optimize MongoDB SCIM query by applying filters before joins #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
789533e
Initial plan
Copilot Jan 15, 2026
d99c62d
Optimize MongoDB query by applying filters before joins
Copilot Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions ...SimpleIdServer.Scim.Persistence.MongoDB/Extensions/MongoDbSCIMExpressionLinqExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,23 @@ public static Expression EvaluateRepresentations(this SCIMComparisonExpression e

#region Filter attributes

public static IMongoQueryable<SCIMRepresentationAttribute> EvaluateMongoDbAttributesDirect(this SCIMExpression expression, IMongoQueryable<SCIMRepresentationAttribute> attributes)
{
var treeNodeParameter = Expression.Parameter(typeof(SCIMRepresentationAttribute), "attr");
var anyWhereExpression = expression.EvaluateAttributesDirect(treeNodeParameter);
if (anyWhereExpression == null) return null;
var enumarableType = typeof(Queryable);
var whereMethod = enumarableType.GetMethods()
.Where(m => m.Name == "Where" && m.IsGenericMethodDefinition)
.Where(m => m.GetParameters().Count() == 2).First().MakeGenericMethod(typeof(SCIMRepresentationAttribute));
var equalLambda = Expression.Lambda<Func<SCIMRepresentationAttribute, bool>>(anyWhereExpression, treeNodeParameter);
var whereExpr = Expression.Call(whereMethod, Expression.Constant(attributes), equalLambda);
var finalSelectArg = Expression.Parameter(typeof(IQueryable<SCIMRepresentationAttribute>), "f");
var finalSelectRequestBody = Expression.Lambda(whereExpr, new ParameterExpression[] { finalSelectArg });
var result = (IMongoQueryable<SCIMRepresentationAttribute>)finalSelectRequestBody.Compile().DynamicInvoke(attributes);
return result;
}

public static IMongoQueryable<EnrichedAttribute> EvaluateMongoDbAttributes(this SCIMExpression expression, IMongoQueryable<EnrichedAttribute> attributes)
{
var treeNodeParameter = Expression.Parameter(typeof(EnrichedAttribute), "tn");
Expand All @@ -126,6 +143,17 @@ public static IMongoQueryable<EnrichedAttribute> EvaluateMongoDbAttributes(this
return result;
}

public static Expression EvaluateAttributesDirect(this SCIMExpression expression, ParameterExpression parameterExpression)
{
var attrExpression = expression as SCIMAttributeExpression;
var logicalExpression = expression as SCIMLogicalExpression;
var comparisonExpression = expression as SCIMComparisonExpression;
if (attrExpression != null) return attrExpression.EvaluateAttributesDirect(parameterExpression);
if (logicalExpression != null) return logicalExpression.EvaluateAttributesDirect(parameterExpression);
if (comparisonExpression != null) return comparisonExpression.EvaluateAttributesDirect(parameterExpression);
return null;
}

public static Expression EvaluateAttributes(this SCIMExpression expression, ParameterExpression parameterExpression)
{
var attrExpression = expression as SCIMAttributeExpression;
Expand All @@ -137,6 +165,19 @@ public static Expression EvaluateAttributes(this SCIMExpression expression, Para
return null;
}

public static Expression EvaluateAttributesDirect(this SCIMAttributeExpression expression, ParameterExpression parameterExpression)
{
var schemaAttributeIdProperty = Expression.Property(parameterExpression, "SchemaAttributeId");
var equal = Expression.Equal(schemaAttributeIdProperty, Expression.Constant(expression.SchemaAttribute.Id));
var complex = expression as SCIMComplexAttributeExpression;
if (complex != null)
{
return complex.GroupingFilter.EvaluateAttributesDirect(parameterExpression);
}

return equal;
}

public static Expression EvaluateAttributes(this SCIMAttributeExpression expression, ParameterExpression parameterExpression)
{
var schemaAttributeIdProperty = Expression.Property(Expression.Property(parameterExpression, "Attribute"), "SchemaAttributeId");
Expand All @@ -150,6 +191,22 @@ public static Expression EvaluateAttributes(this SCIMAttributeExpression express
return equal;
}

public static Expression EvaluateAttributesDirect(this SCIMLogicalExpression expression, ParameterExpression parameterExpression)
{
var leftExpression = expression.LeftExpression.EvaluateAttributesDirect(parameterExpression);
var rightExpression = expression.RightExpression.EvaluateAttributesDirect(parameterExpression);
if (leftExpression == null && rightExpression == null) return null;
if (leftExpression != null && rightExpression == null) return leftExpression;
if (leftExpression == null && rightExpression != null) return rightExpression;
switch (expression.LogicalOperator)
{
case SCIMLogicalOperators.AND:
return Expression.AndAlso(leftExpression, rightExpression);
default:
return Expression.OrElse(leftExpression, rightExpression);
}
}

public static Expression EvaluateAttributes(this SCIMLogicalExpression expression, ParameterExpression parameterExpression)
{
var leftExpression = expression.LeftExpression.EvaluateAttributes(parameterExpression);
Expand All @@ -166,6 +223,29 @@ public static Expression EvaluateAttributes(this SCIMLogicalExpression expressio
}
}

public static Expression EvaluateAttributesDirect(this SCIMComparisonExpression expression, ParameterExpression parameterExpression)
{
var lastChild = expression.LeftExpression.GetLastChild();
if (ParserConstants.MappingStandardAttributePathToProperty.ContainsKey(lastChild.GetFullPath())) return null;
var schemaAttributeId = Expression.Property(parameterExpression, "SchemaAttributeId");
var propertyValueString = Expression.Property(parameterExpression, "ValueString");
var propertyValueInteger = Expression.Property(parameterExpression, "ValueInteger");
var propertyValueDatetime = Expression.Property(parameterExpression, "ValueDateTime");
var propertyValueBoolean = Expression.Property(parameterExpression, "ValueBoolean");
var propertyValueDecimal = Expression.Property(parameterExpression, "ValueDecimal");
var propertyValueBinary = Expression.Property(parameterExpression, "ValueBinary");
var comparison = SCIMExpressionLinqExtensions.BuildComparisonExpression(expression, lastChild.SchemaAttribute,
propertyValueString,
propertyValueInteger,
propertyValueDatetime,
propertyValueBoolean,
propertyValueDecimal,
propertyValueBinary,
parameterExpression,
true);
return Expression.And(Expression.Equal(schemaAttributeId, Expression.Constant(lastChild.SchemaAttribute.Id)), comparison);
}

public static Expression EvaluateAttributes(this SCIMComparisonExpression expression, ParameterExpression parameterExpression)
{
var lastChild = expression.LeftExpression.GetLastChild();
Expand Down
13 changes: 3 additions & 10 deletions src/Scim/SimpleIdServer.Scim.Persistence.MongoDB/SCIMRepresentationQueryRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,13 @@ public async Task<SearchSCIMRepresentationsResponse> FindSCIMRepresentations(Sea
int total = 0;
if (parameter.Filter != null)
{
var filteredRepresentationAttributes = from a in _scimDbContext.SCIMRepresentationAttributeLst.AsQueryable()
join b in _scimDbContext.SCIMRepresentationAttributeLst.AsQueryable() on a.ParentAttributeId equals b.Id into Parents
select new EnrichedAttribute
{
Attribute = a,
Parent = Parents.First(),
Children = new List<SCIMRepresentationAttribute>()
};
filteredRepresentationAttributes = parameter.Filter.EvaluateMongoDbAttributes(filteredRepresentationAttributes);
var filteredRepresentationAttributes = _scimDbContext.SCIMRepresentationAttributeLst.AsQueryable();
filteredRepresentationAttributes = parameter.Filter.EvaluateMongoDbAttributesDirect(filteredRepresentationAttributes);
if (filteredRepresentationAttributes != null)
{
filteredRepresentationIds = (await
filteredRepresentationAttributes
.Select(a => a.Attribute.RepresentationId)
.Select(a => a.RepresentationId)
.ToMongoListAsync())
.Distinct()
.ToList();
Expand Down