Skip to content

Resolve some TODOs#292

Merged
cicnavi merged 12 commits intowip-version-6from
wip-version-6-cleanup
Feb 11, 2025
Merged

Resolve some TODOs#292
cicnavi merged 12 commits intowip-version-6from
wip-version-6-cleanup

Conversation

@cicnavi
Copy link
Copy Markdown
Collaborator

@cicnavi cicnavi commented Feb 11, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 20.89552% with 106 lines in your changes missing coverage. Please review.

Project coverage is 52.53%. Comparing base (af500d3) to head (765513f).

Files with missing lines Patch % Lines
src/Factories/RequestRulesManagerFactory.php 0.00% 42 Missing ⚠️
src/Services/Container.php 0.00% 37 Missing ⚠️
src/Factories/FormFactory.php 0.00% 7 Missing ⚠️
src/Server/RequestRules/Rules/MaxAgeRule.php 0.00% 6 Missing ⚠️
src/Server/RequestRules/Rules/PromptRule.php 0.00% 6 Missing ⚠️
...ntrollers/Federation/EntityStatementController.php 0.00% 2 Missing ⚠️
src/Server/Grants/AuthCodeGrant.php 0.00% 2 Missing ⚠️
src/Factories/Grant/AuthCodeGrantFactory.php 0.00% 1 Missing ⚠️
...er/RequestRules/Rules/ClientAuthenticationRule.php 0.00% 1 Missing ⚠️
src/Services/AuthContextService.php 80.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##             wip-version-6     #292      +/-   ##
===================================================
+ Coverage            52.42%   52.53%   +0.10%     
+ Complexity            1469     1463       -6     
===================================================
  Files                  143      140       -3     
  Lines                 6365     6358       -7     
===================================================
+ Hits                  3337     3340       +3     
+ Misses                3028     3018      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cicnavi cicnavi merged commit 5baeee3 into wip-version-6 Feb 11, 2025
12 checks passed
@cicnavi cicnavi deleted the wip-version-6-cleanup branch February 11, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant