LIBWEB-49: Update react and remove react deprecations#3
Open
kennylindley wants to merge 4 commits intosimplymadeapps:masterfrom
Open
LIBWEB-49: Update react and remove react deprecations#3kennylindley wants to merge 4 commits intosimplymadeapps:masterfrom
kennylindley wants to merge 4 commits intosimplymadeapps:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project is written in LiveScript, we may have to talk about it.
This is also not able to run on CI, because I did not update GULP, which uses node 8. I also removed examples, which have react deprecations, but I did not want to change it.
The deprecations that I addressed are as follows:
createFactoryis deprecated. React recommends converting to JSX or usingcreateElement. Because this is LiveScript, I opted forcreateElement. This also meant that I had to remove thereact-dom-factoriespackage, which usescreateFactoryunder the covers.componentWillReceivePropsis deprecated. These should be refactored to usecomponentDidUpdate.React.createRefhas been deprecated for a while, and that does not work withcreateElement.