Closed
Conversation
- Set staleTime to 0 for useLogDetail hook to always consider cached data stale - Add refetchOnMount: 'always' to ensure fresh data is fetched when a log is selected - Reduce prefetch staleTime to 5 seconds for better consistency This fixes the bug where users needed to hard refresh to see log details of a specific log. The issue was that cached/initial data from the list query wasn't being properly refreshed when selecting a log. Co-authored-by: Emir Karabeg <emir-karabeg@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where log details, particularly
executionData(e.g., trace spans), did not display correctly when selecting a log entry without a hard refresh. TheuseLogDetailhook now ensures detailed log data is always refetched upon selection, overriding stale cached data.Fixes #
Type of Change
Testing
Verify that selecting any log entry on the logs page immediately displays its complete details, including
executionDatalike trace spans, without requiring a hard refresh.Checklist
Screenshots/Videos
Slack Thread