fix(emails): re-export the wordmark onto its original canvas - #6651
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Introduces Tests now pin the PNG IHDR to the canvas, assert display-box vs canvas aspect (not viewBox), and retain retina/coverage checks for the glyph outlines. Reviewed by Cursor Bugbot for commit 97b22a6. Configure here. |
Greptile SummaryThe PR restores the email wordmark raster to its 272×164 canvas and updates the branding constants and tests to pin that canvas and its 43×26 display box.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up review scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/branding/wordmark.ts | Defines the frozen 272×164 email canvas and changes the rendered wordmark box to 43×26. |
| apps/sim/lib/branding/wordmark.test.ts | Pins the raster dimensions and validates display-box aspect and resolution against the declared canvas. |
| apps/sim/public/brand/color/email/wordmark.png | Replaces the email wordmark raster with the restored canvas export. |
Reviews (2): Last reviewed commit: "fix(emails): re-export the wordmark onto..." | Re-trigger Greptile
#6648 shrank the header wordmark by re-exporting the raster edge-to-edge at 168x80, replacing a 272x164 file whose mark was inset. Same URL, new proportions — so every email already delivered, which keeps the width=68 height=41 it was sent with and refetches that URL forever, now stretches the mark ~20%, and a client still holding the old bytes squashes it ~22% into the new box. That is the squished logo on staging. Re-export onto the original 272x164 canvas instead, with the outlines at their own aspect (the previous asset was itself 3.9% squashed) and the textBody fill. Old mail renders against its own numbers as before; the header takes a 43x26 box for 20.7px of ink. A test pins the canvas, since that shape — not the display size — is what old mail depends on.
5d28a2e to
97b22a6
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 97b22a6. Configure here.
Summary
width=68 height=41it was sent with and refetches that URL forever, so it now stretches the new file's mark ~20%textBody, matching the landing navbar's--text-body.43x26box, rendering 20.7px of ink — the landing navbar's rule (neighbouring text + 2px above and below) applied to 16px email body copy.Type of Change
Testing
vitest run lib/branding components/emails— 37 passing. Verified the new canvas guard goes red on exactly the improvement(emails): size the header wordmark to the landing navbar's rule #6648 mistake: swapping in the 168x80 export fails withexpected { width: 168, height: 80 } to deeply equal { width: 272, height: 164 }.src=".../wordmark.png" width="43" height="26".tsgo --noEmitand biome clean.Checklist