Skip to content

🐛 Fix non-ascii names in offline mode #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzscisoft merged 1 commit into from
Aug 11, 2025
Merged

🐛 Fix non-ascii names in offline mode #834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion simvue/factory/proxy/offline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import time
import typing
import uuid
import unicodedata
import randomname

from simvue.factory.proxy.base import SimvueBaseClass
Expand Down Expand Up @@ -65,6 +66,15 @@ def _mock_api_post(
self._write_json(filename, data)
return data

@staticmethod
def _generate_random_name() -> str:
"""Generates a random name with only valid ASCII characters."""
return (
unicodedata.normalize("NFKD", randomname.get_name())
.encode("ascii", "ignore")
.decode("ascii")
)

@skip_if_failed("_aborted", "_suppress_errors", (None, None))
def create_run(self, data) -> tuple[str, str | None]:
"""
Expand All @@ -75,7 +85,7 @@ def create_run(self, data) -> tuple[str, str | None]:
return (None, None)

if not self.name:
self.name = randomname.get_name()
self.name = self._generate_random_name()

try:
os.makedirs(self._directory, exist_ok=True)
Expand Down