Skip to content

Don't commit artifact in sender #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzscisoft merged 1 commit into from
Aug 15, 2025
Merged

Don't commit artifact in sender #841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion simvue/sender.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from simvue.config.user import SimvueConfiguration

import simvue.api.objects
from simvue.api.objects.artifact.base import ArtifactBase
from simvue.eco.emissions_monitor import CO2Monitor
from simvue.version import __version__

Expand Down Expand Up @@ -81,7 +82,8 @@ def upload_cached_file(
obj_for_upload.on_reconnect(id_mapping)

try:
obj_for_upload.commit()
if not issubclass(_instance_class, ArtifactBase):
obj_for_upload.commit()
_new_id = obj_for_upload.id
except RuntimeError as error:
if "status 409" in error.args[0]:
Expand Down