Merged
Conversation
simylein
requested changes
May 24, 2025
setup.sh
Outdated
| @@ -361,7 +361,7 @@ elif [[ ${versionArg} == true ]]; then | |||
| version="${versionVal}" | |||
| case ${version} in | |||
| "1.21.4") | |||
Owner
There was a problem hiding this comment.
I am very sorry about the messy code structure, but this is the 6th place which needs adjustment like the others. 1.21.4 => 1.21.5
Contributor
Author
There was a problem hiding this comment.
Going forward, should these be a global variable that only has to be changed once ?
Owner
There was a problem hiding this comment.
Yeah maybe, although they span multiple files and would need to be in a common file which is read by every script like server.settings, maybe I will try something someday, maybe not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Love your work !
Updated your repo to use the latest version of minecraft :)