Adjust test from last PR (Version Bumps and Directory Changes) #39
Conversation
|
Something is failing the scripts in Actions. I'm on it Edit: |
internettrans
left a comment
internettrans
left a comment
There was a problem hiding this comment.
The error in CI seems to be occurring during the vue invoke single-spa command. Vue CLI runs pnpm install --reporter silent as shown in https://github.com/single-spa/vue-cli-plugin-single-spa/pull/39/checks?check_run_id=3678996808#step:7:35
The --reporter silent swallows the error which is why there isn't more useful info. Trying to find a way to get it not use the silent reporter would be the best way to debug. If we can't figure it out we can try switching to npm rather than pnpm for the vue cli projects.
| mkcdir () | ||
| { | ||
| mkdir -p -- "$1" && | ||
| cd -P -- "$1" |
There was a problem hiding this comment.
Changing directories during the test command is not great, as when the tests failed the user will be confused as to why their terminal is suddenly in a new directory compared to when they started it. Instead, let's use pnpm --dir flag:
There was a problem hiding this comment.
While we can use --dir for later executions once the application is created this won't apply to vue cli.
So I'm not sure if that will improve things a lot.
vue create --help
Does not list a similar function like pnpm --dir
There was a problem hiding this comment.
In that case, it would be best to try to catch the error and return the user back to their original working directory, if possible.
There was a problem hiding this comment.
It should do that by default since concurrently creates sub Processes right? The Process the Users Terminal is running in won't change.
|
The problem with the pnpm issue is that i cant reproduce it on either MacOS nor Windows10. I'll setup a Ubuntu VM and run some tests there. |
|
Ok only took me 2 months to come back to this issue (sorry for that). But I moved the tests over to npm (still can't get pnpm to work). Also renamed the step to just test. |
2 participants
Hi,
the two commits applying the Change Requests from #38
Windows compatibility:
Well the script itself runs on windows without a problem (tested with git Bash). The Problem is the Path separator ( / vs \ )in the package.json. I don't really know if there is a solution that could be applied here easily.