-
-
Notifications
You must be signed in to change notification settings - Fork 99
Add support for LokiOrgID configuration and update HTTP headers accor… #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be32896 to
4544554
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds initial support for configuring a Loki tenant/organization ID and using it in Loki HTTP requests.
Changes:
- Added
LokiOrgIDto the main configuration struct. - Switched the Loki connectivity check from
http.Getto an explicit request so a custom header can be set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
remotelog/loki.go |
Builds a GET request for the Loki label endpoint and conditionally sets X-Scope-OrgID. |
config/config.go |
Introduces the LokiOrgID configuration field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@ggontariu thank you - please check the Copilot reply. |
4544554 to
82833e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@ggontariu please review the Copilot's reply. |
3ba5266 to
b905bf6
Compare
|
@adubovikov remotelog/loki had no tests. I added test_loki.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
48992bc to
16be4a0
Compare
|
@adubovikov Comments resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…dingly