Skip to content

Conversation

@ggontariu
Copy link
Contributor

…dingly

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2026

CLA assistant check
All committers have signed the CLA.

@ggontariu ggontariu force-pushed the Add-multi-tenancy branch 5 times, most recently from be32896 to 4544554 Compare January 23, 2026 15:59
@kYroL01 kYroL01 added the enhancement New feature or request label Jan 23, 2026
@adubovikov adubovikov requested a review from Copilot January 23, 2026 17:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds initial support for configuring a Loki tenant/organization ID and using it in Loki HTTP requests.

Changes:

  • Added LokiOrgID to the main configuration struct.
  • Switched the Loki connectivity check from http.Get to an explicit request so a custom header can be set.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
remotelog/loki.go Builds a GET request for the Loki label endpoint and conditionally sets X-Scope-OrgID.
config/config.go Introduces the LokiOrgID configuration field.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adubovikov
Copy link
Member

@ggontariu thank you - please check the Copilot reply.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adubovikov
Copy link
Member

@ggontariu please review the Copilot's reply.

@ggontariu ggontariu force-pushed the Add-multi-tenancy branch 2 times, most recently from 3ba5266 to b905bf6 Compare January 26, 2026 06:28
@ggontariu
Copy link
Contributor Author

ggontariu commented Jan 26, 2026

@adubovikov remotelog/loki had no tests. I added test_loki.go

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ggontariu
Copy link
Contributor Author

@adubovikov Comments resolved

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adubovikov adubovikov merged commit 3c5bdc8 into sipcapture:master Jan 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants