fix(code-release): remove + from PyPI package name and opt into Node.js 24 runner#94
Merged
Merged
Conversation
…Node.js 24 runner
There was a problem hiding this comment.
Pull request overview
This PR fixes the release workflow by correcting the generated Python package distribution name and opting the workflow into the Node.js 24 JavaScript action runtime ahead of the GitHub Actions cutoff.
Changes:
- Renames the generated PyPI package from
PowerTraderAI+toPowerTraderAI. - Adds
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24to the workflow environment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two issues identified from CI run #33, triggered by the merge of PR #88:
1. Build failure - invalid PyPI package name (exit code 1)
The Create Python package step failed with:
Root cause:
name="PowerTraderAI+"in the inlinesetup.pyheredoc. The+character is not permitted in distribution names per PEP 508.setuptoolsnormalises it to-, which then combines with the version separator to produce the double-dashPowerTraderAI--string that triggers the error.Fix: rename the package from
"PowerTraderAI+"to"PowerTraderAI"in thesetup()call.2. Warning - Node.js 20 action deprecation (upcoming hard failure 2 June 2026)
The runner reported:
Fix: add
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueto the workflowenvblock, opting in now before the forced cutover on 2 June 2026.Changes
.github/workflows/code-release.ymlname="PowerTraderAI+"->name="PowerTraderAI"insetup()callFORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueto top-levelenvblock