Skip to content

fix(code-release): remove + from PyPI package name and opt into Node.js 24 runner#94

Merged
sjackson0109 merged 2 commits into
mainfrom
fix/code-release-package-name-and-node24
May 20, 2026
Merged

fix(code-release): remove + from PyPI package name and opt into Node.js 24 runner#94
sjackson0109 merged 2 commits into
mainfrom
fix/code-release-package-name-and-node24

Conversation

@sjackson0109

Copy link
Copy Markdown
Owner

Problem

Two issues identified from CI run #33, triggered by the merge of PR #88:

1. Build failure - invalid PyPI package name (exit code 1)

The Create Python package step failed with:

error: Invalid distribution name or version syntax: PowerTraderAI--2026.5.18+c3a2d85

Root cause: name="PowerTraderAI+" in the inline setup.py heredoc. The + character is not permitted in distribution names per PEP 508. setuptools normalises it to -, which then combines with the version separator to produce the double-dash PowerTraderAI-- string that triggers the error.

Fix: rename the package from "PowerTraderAI+" to "PowerTraderAI" in the setup() call.

2. Warning - Node.js 20 action deprecation (upcoming hard failure 2 June 2026)

The runner reported:

Node.js 20 actions are deprecated. Actions will be forced to run with Node.js 24
by default starting June 2nd, 2026.
Affected: actions/checkout@v4, actions/setup-python@v5

Fix: add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true to the workflow env block, opting in now before the forced cutover on 2 June 2026.

Changes

  • .github/workflows/code-release.yml
    • name="PowerTraderAI+" -> name="PowerTraderAI" in setup() call
    • Added FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true to top-level env block

Copilot AI review requested due to automatic review settings May 19, 2026 21:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the release workflow by correcting the generated Python package distribution name and opting the workflow into the Node.js 24 JavaScript action runtime ahead of the GitHub Actions cutoff.

Changes:

  • Renames the generated PyPI package from PowerTraderAI+ to PowerTraderAI.
  • Adds FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 to the workflow environment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sjackson0109 sjackson0109 self-assigned this May 19, 2026
@sjackson0109 sjackson0109 requested a review from Copilot May 20, 2026 00:04
@sjackson0109 sjackson0109 merged commit b0dcc2a into main May 20, 2026
19 of 20 checks passed
@sjackson0109 sjackson0109 removed the request for review from Copilot May 20, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants