[ENH] experimental get_tag hybrid method callable on class and instance#560
Draft
fkiraly wants to merge 6 commits into
Draft
[ENH] experimental get_tag hybrid method callable on class and instance#560fkiraly wants to merge 6 commits into
get_tag hybrid method callable on class and instance#560fkiraly wants to merge 6 commits into
Conversation
fkiraly
added
API design
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… into get_tag-hybridmethod
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an experimental design study that modifies
get_tagandget_tagsmethods ofBaseObjectso it is callable on classes as well as on instances.In the current case,
get_taggets rerouted toget_class_tagif called on a class, andget_tagssimilarly toget_class_tags.Ultimately, this could allow
get_tagandget_tagsas the single interface point for tags.