Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Dec 16, 2025

Summary

This PR gathers the latest version for Windows installations from the releases metadata now found at:

🔗 https://docs.slack.dev/tools/metadata.json

This fixes #296 which might've relied on multiple entries of releases beforehand 🤔

Requirements

@zimeg zimeg self-assigned this Dec 16, 2025
@zimeg zimeg added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label Dec 16, 2025
@zimeg zimeg requested a review from a team as a code owner December 16, 2025 00:22
@zimeg zimeg added the semver:patch Use on pull requests to describe the release version increment label Dec 16, 2025
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.87%. Comparing base (b724d81) to head (a06a02c).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   64.87%   64.87%           
=======================================
  Files         213      213           
  Lines       17550    17550           
=======================================
+ Hits        11385    11386    +1     
+ Misses       5101     5099    -2     
- Partials     1064     1065    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@cchensh cchensh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the installation script @zimeg :hero

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we could add CI tests for this script somehow? 🤔

@zimeg
Copy link
Member Author

zimeg commented Dec 16, 2025

@cchensh @WilliamBergamin @srtaalej Thanks so much for the quick reviews 🙏 ✨

Any way we could add CI tests for this script somehow?

Before merging this, I'll look into adding a few Windows tests to this PR. Thank you for calling this out - it's still not clear to me when this started to fail without such! 👾

@zimeg
Copy link
Member Author

zimeg commented Dec 17, 2025

🤖 issue: Windows in CI is difficult to test I'm finding... I reverted the testing attempts in this PR and find that these scripts work on a personal machine so I'll merge this.

🗣️ ramble: The issue of CI testing isn't clear to me but seems related to updating the path to the installation within the script and with some CI specific settings. I have note to follow up on this if new insights appear!

@zimeg zimeg merged commit d54492c into main Dec 17, 2025
8 checks passed
@zimeg zimeg deleted the zimeg-fix-windows-install-version branch December 17, 2025 00:37
@zimeg zimeg added this to the Next Release milestone Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Slack CLI Windows powershell installer version error

5 participants