Skip to content

add getUnixTime function#16

Open
howard-wong wants to merge 1 commit intosleemanj:masterfrom
howard-wong:master
Open

add getUnixTime function#16
howard-wong wants to merge 1 commit intosleemanj:masterfrom
howard-wong:master

Conversation

@howard-wong
Copy link

No description provided.

@sleemanj
Copy link
Owner

sleemanj commented Oct 25, 2018

Thank you for the PR.

Leap year calculation appears incomplete, for example 2100 will not be a leap year but your code would include it I think.

"dim" and "a_dim" are not very descriptive names

I'm not sure about dim[i] unless this is a new feature of GCC handling it automatically, since a_dim is in PROGMEM the program memory reading functions (pgm_read_byte specifically) need to be used, without retrieving the data in this manner you are just grabbing random junk from a ram location, not the flash location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants