Removal of GetNextMut and Atom::replace_and_set_next#10
Open
dbkaplun wants to merge 1 commit intoslide-rs:masterfrom
Open
Removal of GetNextMut and Atom::replace_and_set_next#10dbkaplun wants to merge 1 commit intoslide-rs:masterfrom
dbkaplun wants to merge 1 commit intoslide-rs:masterfrom
Conversation
torkleyy
reviewed
May 18, 2018
Member
torkleyy
left a comment
torkleyy
left a comment
There was a problem hiding this comment.
Well I liked it. I don't see a reason to remove it.
Contributor
Author
|
I like it too. I just think it's strange to have a linked list function in this package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods have little to do with Atom's usage and should be removed. They are specific to linked lists, and are not relevant to safe atomic pointers. Atomic linked lists can be implemented in various ways, and although a spin lock is one way, it seems like bikeshedding to me.
Opening this up for discussion, as I think this is something that should be addressed.