Conversation
- define Go structs mirroring C ADBC and Arrow C Data Interface memory layouts - include structs for schema, array, stream, error, database, connection, statement, partitions - add ADBC status codes and driver manager load flags - introduce purego dependency for foreign function interface compatibility
- add `loadDriverManagerLibrary` to dynamically load the ADBC driver manager shared library - utilize `purego` for platform-specific library loading (darwin, linux, windows) - allow overriding library path via `ADBC_DRIVER_MANAGER_LIB` environment variable - introduce `registerFunctions` as a placeholder for future ADBC function bindings
- register all adbc api functions for database, connection, statement, and error - support both adbc 1.0.0 and 1.1.0 specifications - utilize purego to dynamically load and bind c functions
- introduce utilities for converting between c and go strings - implement conversion from c adbcerror to go adbc.error - handle releasing c adbcerror resources - provide functions for allocating zeroed c arrow and adbcerror structs
- delete c++ implementation of adbc driver manager - remove direct cgo calls and cgo directives from go driver manager wrapper - update string options to use go byte slices instead of cgo char pointers - introduce explicit library loading for the driver manager shared library
- add nil checks to prevent panics when closing already released resources - nullify underlying C pointers after release to ensure proper state
- provide guidance on how to specify the library path - suggest using `ADBC_DRIVER_MANAGER_LIB` environment variable to resolve loading issues
- introduce `loadLibrary` function for platform-specific library loading - use `purego.Dlopen` for Unix-like systems (Linux, macOS) - use `syscall.LoadLibrary` for Windows - decouple `purego` import to platform-specific files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.