step-issuer: make securityContext nullable#241
Open
wtcross wants to merge 1 commit intosmallstep:masterfrom
Open
step-issuer: make securityContext nullable#241wtcross wants to merge 1 commit intosmallstep:masterfrom
wtcross wants to merge 1 commit intosmallstep:masterfrom
Conversation
|
|
github-actions
bot
added
the
needs triage
Author
|
Would anyone mind taking a look at this? This chart is fairly straightforward and I don't mind managing my own version, but would prefer to contribute upstream if possible. I'm trying to learn so I'm also 100% fine with an explanation of why this change wouldn't make sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am deploying
step-issueron OpenShift 4.20, which uses kubernetes 1.33. I am using version1.9.11of the chart, which is orchestrated by ArgoCD.This change makes the following values nullable:
securityContextpodSecurityContextkubeRBACproxy.securityContextThis simplifies deployment to OpenShift since the default SCC is
restricted-v3, which is used for any pods that don't have securityContext defined.I'm not very experienced with Helm. Let me know if this is a reasonable suggestion. It will not break anything for existing chart users.
I didn't make this change in the other charts in the repo. I also did not bump the version. If the maintainers like this change let me know how you'd prefer versioning to be handled.
❤Thank you!