Skip to content

Models for M350+DJI controller - #243

Merged
KKalem merged 3 commits into
smarc-project:masterfrom
03alebassi-debug:feature/identified-system
Aug 3, 2026
Merged

Models for M350+DJI controller#243
KKalem merged 3 commits into
smarc-project:masterfrom
03alebassi-debug:feature/identified-system

Conversation

@03alebassi-debug

Copy link
Copy Markdown
  • Implemented the DiscreteTF class, which takes the parameters of a discrete transfer function sampled at 50 Hz (simulation frequency) as input and computes the discrete update. The class is generic and supports transfer functions of any order.

  • Implemented a specific model + controller for each axis, along with an additional attitude controller.

@KKalem KKalem left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • X,Y,Z controllers do not match their definition in Unity, use "forward, left, up" wording instead to avoid confusion.
  • These 3 are nearly identical except the numbers... please merge "X,Y" into one "horizontal controller" and rename "Z" into "altitude controller".
    • Use some prefix to differentiate these from the generic ones. "Sysid_horizontal_controller" or sth is ok.
  • I also would like to avoid future questions of "how can i use this for my other robot", so place all this under DJI instead, right next to "DJIController.cs".
    • The ultimate goal is to replace the horizontal, altitude and attitude controller scripts that the DJIController uses with these instead. So the more similar they are the better.
  • Add a link to something that describes the parameters. b, aTail, invA0 etc are not at all things that can be modified without some text and math. A readme would do too.

@03alebassi-debug
03alebassi-debug marked this pull request as draft July 20, 2026 10:15
…md, adjusted the altitude controller to be similar to the existing one
@03alebassi-debug
03alebassi-debug requested a review from KKalem July 20, 2026 14:42

@KKalem KKalem left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple little things here and there, but I'll fix'em up later. just some housekeeping.

@03alebassi-debug
03alebassi-debug marked this pull request as ready for review July 31, 2026 08:18
@KKalem
KKalem merged commit 10ee6a1 into smarc-project:master Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants