Models for M350+DJI controller - #243
Merged
KKalem merged 3 commits intoAug 3, 2026
Merged
Conversation
KKalem
requested changes
Jul 17, 2026
KKalem
left a comment
There was a problem hiding this comment.
- X,Y,Z controllers do not match their definition in Unity, use "forward, left, up" wording instead to avoid confusion.
- These 3 are nearly identical except the numbers... please merge "X,Y" into one "horizontal controller" and rename "Z" into "altitude controller".
- Use some prefix to differentiate these from the generic ones. "Sysid_horizontal_controller" or sth is ok.
- I also would like to avoid future questions of "how can i use this for my other robot", so place all this under DJI instead, right next to "DJIController.cs".
- The ultimate goal is to replace the horizontal, altitude and attitude controller scripts that the DJIController uses with these instead. So the more similar they are the better.
- Add a link to something that describes the parameters.
b,aTail,invA0etc are not at all things that can be modified without some text and math. A readme would do too.
03alebassi-debug
marked this pull request as draft
July 20, 2026 10:15
…md, adjusted the altitude controller to be similar to the existing one
KKalem
approved these changes
Jul 27, 2026
KKalem
left a comment
There was a problem hiding this comment.
Couple little things here and there, but I'll fix'em up later. just some housekeeping.
03alebassi-debug
marked this pull request as ready for review
July 31, 2026 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the DiscreteTF class, which takes the parameters of a discrete transfer function sampled at 50 Hz (simulation frequency) as input and computes the discrete update. The class is generic and supports transfer functions of any order.
Implemented a specific model + controller for each axis, along with an additional attitude controller.