Skip to content

drop cdep support #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krzysztofequativ merged 1 commit into from
Nov 21, 2025
Merged

drop cdep support #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions modules/sharethroughBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ export const sharethroughAdapterSpec = {
}
}

if (bidderRequest.ortb2?.device?.ext?.cdep) {
req.device.ext['cdep'] = bidderRequest.ortb2.device.ext.cdep;
}

// if present, merge device object from ortb2 into `req.device`
if (bidderRequest?.ortb2?.device) {
mergeDeep(req.device, bidderRequest.ortb2.device);
Expand Down
7 changes: 2 additions & 5 deletions modules/smartadserverBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export const spec = {
return 3;
}
}
return 1; // SADR-5619
return 1;
},

/**
Expand All @@ -165,10 +165,7 @@ export const spec = {
return {
method: 'POST',
url: (domain !== undefined ? domain : 'https://prg.smartadserver.com') + '/prebid/v1',
data: JSON.stringify(payload),
options: {
browsingTopics: false
}
data: JSON.stringify(payload)
};
},

Expand Down
37 changes: 0 additions & 37 deletions test/spec/modules/sharethroughBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,43 +895,6 @@ describe('sharethrough adapter spec', function () {
});
});

describe('cookie deprecation', () => {
it('should not add cdep if we do not get it in an impression request', () => {
const builtRequests = spec.buildRequests(bidRequests, {
auctionId: 'new-auction-id',
ortb2: {
device: {
ext: {
propThatIsNotCdep: 'value-we-dont-care-about',
},
},
},
});
const noCdep = builtRequests.every((builtRequest) => {
const ourCdepValue = builtRequest.data.device?.ext?.cdep;
return ourCdepValue === undefined;
});
expect(noCdep).to.be.true;
});

it('should add cdep if we DO get it in an impression request', () => {
const builtRequests = spec.buildRequests(bidRequests, {
auctionId: 'new-auction-id',
ortb2: {
device: {
ext: {
cdep: 'cdep-value',
},
},
},
});
const cdepPresent = builtRequests.every((builtRequest) => {
return builtRequest.data.device.ext.cdep === 'cdep-value';
});
expect(cdepPresent).to.be.true;
});
});

describe('first party data', () => {
const firstPartyData = {
site: {
Expand Down
7 changes: 0 additions & 7 deletions test/spec/modules/smartadserverBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,13 +461,6 @@ describe('Smart bid adapter tests', function () {
expect(syncs).to.have.lengthOf(0);
});

it('should set browsingTopics=false in request.options', () => {
const requests = spec.buildRequests(DEFAULT_PARAMS_WO_OPTIONAL);
expect(requests[0]).to.have.property('options').and.to.deep.equal({
browsingTopics: false
});
});

it('Verify metadata', function () {
const adomain = ['advertiser-domain.com'];
const dsa = {
Expand Down
Loading