Add a new slider in graphics to select the quality (Potato, Fast and Fancy)#1188
Add a new slider in graphics to select the quality (Potato, Fast and Fancy)#1188Bakoubak wants to merge 9 commits intosmartcmd:mainfrom
Conversation
* Potato Mode for very low end devices, sets particules to minimal, graphics to fast and disables Ambient Occlusion. * Fast Mode for low/mid end devices, sets particules to decreased, graphics to fast with Ambient Occlusion. * Fancy Mode for mid/hight end devices, sets particules to maximum, graphics to fancy with Ambient Occlusion
|
Here are the results: [Potato Mode] [Fast Mode] [Fancy Mode] |
|
github seems to have mixed up every pictures... It goes from potato, fast to fancy. |
|
que versión usa Minecraft Legacy Edition |
|
why are all of the sliders just white |
Im running on wine, it works fine on Proton-GE for some reason lmao |
|
Added hot reload capabilities instead of having to leave everytime to apply the settings |
|
I'd recommend modifying your .swf files a tad with the fix detailed here: #1092 just so the background looks a little nicer. |
|
sure I'll do it asap |
|
@jvnpr it should be fixed with the latest commit, the window is no more stretched |
Co-authored-by: rtm516 <rtm516@users.noreply.github.com>
Co-authored-by: rtm516 <rtm516@users.noreply.github.com>
|
Should be okay now |
|
@rtm516 Will this be merged soon (before I forget about it ?) |
| int currentGraphics = app.GetGameSettings(m_iPad, eGameSetting_GraphicsMode); | ||
|
|
||
| const wchar_t* graphicsText = L""; | ||
| if (currentGraphics == 0) graphicsText = L"Graphics: Potato"; |
There was a problem hiding this comment.
nit (i am not a reviewer): "Potato" is very un-minecrafty. Would suggest "Efficient" or similar.
There was a problem hiding this comment.
I'm pretty sureee "Potato" has been used before in some official way, and even if not, I don't think it's that out-of-character
There was a problem hiding this comment.
I'm pretty sure it was already used somewhere in Minecraft, so it doesn't seem like it's out of place
7 participants
Description
This PR adds a new slider in graphics to configure the current graphics level (Potato, Fast and Fancy)
(I think this supports the community guidelines, it is integrated in the code but never used and it is nice for peoples with older/weaker computers)
Previous Behavior
The game always assumed Fancy as the default
Root Cause
Graphics mode switching was never implemented and can be helpfull for older devices or weaker configurations.
New Behavior
Added a new slider in graphics to select the graphics quality
Fix Implementation
Added the slider in the SWF (Iggy), packed it in the .arc, then i added most of the code for this in the cpp side. Clouds are set to 2d for potato and fast, Leaves as fast for potato and fast, and ambient occlusion is disabled for potato.
AI Use Disclosure
The only use of AI here was to vibecode an arc opener/editor, and to understand how i was supposed to mess with the swf file. The code is authored only by myself.
Related Issues