Java texture packs

[Soggy-Pancake]

Description

Adds java texture pack support

Changes

Loads texture packs from zip files.

Previous Behavior

DLC pack files only

New Behavior

Texture packs are found on game start and are added to the list of available packs.

Fix Implementation

• Added bit7z library with 7z.dll for zip file loading
• Implemented ZipFile, ZipEntry, and FileTexturePack classes
• Updated all tile and item names to match current versions
• Auto atlas generation using matched names to find textures
• Most atlas icon positions are now tied to the item/tile instance name to allow easier name changes in the future
• Not all were able to be updated as they have multiple icon variants

AI Use Disclosure

Some scanning to understand parts of the codebase and as interactive documentation of cpp.

Current issues

• No folder loading yet
• Packs <16px are busted by animated textures
• Partial blocks like end portal frames and beds break with smaller packs as well due to rounding.

[deffcolony]

Hi @Soggy-Pancake
I've actually managed to pull every single official DLC pack released for the console editions directly from my PS3. It's a total of 70 folders, including all the skins, texture packs, and maps.
I'd like to work with you to get all of these implemented into the project. I took a look at how the other DLCs were set up, and I already have tools like FFmpeg and vgmstream ready to convert the Bink audio files to .ogg.
I think adding these would finally complete the entire DLC collection. Would you be interested in collaborating on this? If so, is there somewhere we could chat more easily, like Discord? Let me know!

[Soggy-Pancake]

@deffcolony I haven't really worked much with dlc packs or any of that stack tbh. I could maybe take a look as it could still be helpful for other portions of packs to work. I've mostly sidestepped the dlc code and only interact with PreStitchedTextureMap and a bit of file stuff.

[deffcolony]

@Soggy-Pancake I've send you a DM on Discord

[Soggy-Pancake]

Library files got ignored for some reason, just force added them so now it should be able to find them

[Sab44]

This would be awesome to have. Is there any upper limit on texture size that's supported?

[Soggy-Pancake]

No upper limit. The way I get the pack size is a bit dumb as I just use whatever size the dirt texture is, but I dont want to read in every single texture to find the largest one and then write the atlas. The atlas is just the texture size times icons in each dimension. The animated textures are bit of a problem rn and I havent looked into it too much yet. Items become tiny if the pack is large and if the pack is smaller than 16x then animated blocks begin to overwrite other blocks.

[Soggy-Pancake]

Folders now load as well as animated textures that aren't animated by default are now cropped to the first frame. I'm unsure of how to fix blocks with models occasionally breaking with packs <16px. It is completely visual though and doesn't impact most packs people would use.

[Soggy-Pancake]

alright got it to finish the github action on mine :D

[Wisg-The-Cat]

Alr so i want to use this and i have ABSOLUTELY NO IDEA how to downlaod this and put it in my "night build" or whatever it means just to clarify IM A NEWBIE I MADE THIS ACCOUNT JUST TO ASK HELP.

[Soggy-Pancake]

@Wisg-The-Cat You can go to my repo and go to the releases page. There will be a nightly build and that is a build that contains the patches for loading texture packs.

[Wisg-The-Cat]

Ty :3

[Wisg-The-Cat]

@Soggy-Pancake Where do i find and where do i put texture packs (help)

[Soggy-Pancake]

resourcepacks folder in the same folder as the client exe

[sylvessa]

mashup pack iossues

tile entities such as chests, ender chests, and trapped chest do not get assigned their texture properly in the mashup packs

same with certain mobs (such as creepers, skeletons, and spiders):

mobs that seem to be affected:

• spider
• creeper
• skeleton
• pig
• slime
• ghast
• enderman
• cave spider
• silverfish
• blaze
• magma cube
• bat
• sheeps inner layer (the wool works)
• cow
• chicken
• squid
• wolf
• mooshroms (the mushroom itself works)
• ocelots
  other mobs work fine

mob heads do not also work properly

java texture pack issues

packs that contain special character names (such as one i have: ! §6§lDeos 2k Pack§r§6.zip) do not work, they simply crash the game

i even tried texture packs from 1.6 such as faithful and dokucraft, and modern minecraft, i couldnt get any of them to load
i tried 1.6.4 dokucraft, some 1.7 texture packs, a 1.20 texture pack, a 1.8 texture pack, and none of them would load into the game, immediately crashing

texture packs tested:
dokucraft high (1.6.2)
dokucraft dark (1.6.2)
dokucraft light (1.6)
pretty much every version of faithful
and some other old texture packs that i used in 2014 which also didnt work
Even tried to make texture packs that would only replace like a few blocks, it either did the same thing (crash upon world creation or loading a normal world) or crash upon startup

I dont know why, but I could never get a texture pack to load no matter what i did, this should be looked into.

[sylvessa]

this is still something that would be cool to have, it just needs more work

[Soggy-Pancake]

Chests had their models flipped so I disabled loading them as the bottom became the top for some reason. I don't know how to fix the issues with special characters not loading. I could rename the file to something that doesn't use special characters on load but that doesn't seem like the best idea. I'll test with the resulting build from the github action cuz maybe the 7z.dll file is missing or something.

[sylvessa]

Chests had their models flipped so I disabled loading them as the bottom became the top for some reason. I don't know how to fix the issues with special characters not loading. I could rename the file to something that doesn't use special characters on load but that doesn't seem like the best idea. I'll test with the resulting build from the github action cuz maybe the 7z.dll file is missing or something.

The 7z.dll file is there, it was under windows64media. I tried moving it to be next to the exe as well and that didnt make a difference