Deprecate xvfb in favor of wlheadless-run#1450
Draft
Twig6943 wants to merge 4 commits intosmartcmd:mainfrom
Draft
Deprecate xvfb in favor of wlheadless-run#1450Twig6943 wants to merge 4 commits intosmartcmd:mainfrom
Twig6943 wants to merge 4 commits intosmartcmd:mainfrom
Conversation
Collaborator
|
x11 dying is not a cause. is there something wrong that truly would require something like this to be done? i feel theres no reason for this to be done unless theres somethng wrong |
Collaborator
|
this is too opinionated to merge without actual justification behind making this change. "x11 is dying yada yada" is not sufficient technical reasoning for us to change anything. please amend your PR to explain why your solution is better and how it doesn't break support with existing use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switched to wlheadless-run & also upgraded to debian trixie because bookworm doesn't have the package xwayland-run
I tested and it works;
Changes
Previous Behavior
x11
Root Cause
x11 is dying yada yada
New Behavior
Switched to wayland
Fix Implementation
Switch to wayland
AI Use Disclosure
No.
Side note: The other PR I have going on that also adds proton is on hold due to this issue ValveSoftware/Proton#9632