Fix linting report #1774
Draft
Fix linting report #1774
+154
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chainchad
commented
Jan 14, 2026
chainchad
commented
- add nop info lookup token
- refactoring
- make headerfunc unexported
- fix testifylint errors
- fix import order
- Update pkg/chipingress/client_test.go
- Enable continue-on-error for golangci_lint job
- Use module path for golangci-lint report XML
- Add debug step to find path to xml report for golangci-lint
- refactor for lint
- Show working dir
- Revert "Show working dir"
- Revert "Add debug step to find path to xml report for golangci-lint"
- Revert "refactor for lint"
Co-authored-by: Jordan Krage <jmank88@gmail.com>
Allow module linting to continue on errors.
…token' of https://github.com/smartcontractkit/chainlink-common into feature/INFOPLAT-3250-chip-ingress-add-nop-info-lookup-token
This reverts commit 46d22f6.
This reverts commit 36b468d.
This reverts commit dcb4562.
✅ API Diff Results - No breaking changes |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
chainchad
had a problem deploying
to
integration
GitHub Actions
Failure
| if: ${{ always() && !contains(join(github.event.pull_request.labels.*.name, ' '), 'allow-lint-issues') }} | ||
| # NOTE: Keep this version in sync with ACTION_CI_LINT_GO_GIT_TAG in ./script/lint.sh | ||
| uses: smartcontractkit/.github/actions/ci-lint-go@ci-lint-go/3.0.0 | ||
| uses: smartcontractkit/.github/actions/ci-lint-go@dx-2618/golangci-lint # TODO - use versioned release |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.