[POC] feat(deployment): add domain config getter#825
[POC] feat(deployment): add domain config getter#825graham-chainlink wants to merge 1 commit intomainfrom
Conversation
|
Add an Environment-level DomainConfigGetter interface with an os.Getenv-backed implementation, and cover default wiring plus getter behavior with focused deployment tests.
graham-chainlink
force-pushed
the
ggoh/config-getter
branch
from
0246ab2 to
f1d4e79
Compare
|
graham-chainlink
changed the title
| OCRSecrets: e.OCRSecrets, | ||
| OperationsBundle: e.OperationsBundle, | ||
| BlockChains: e.BlockChains, | ||
| DomainConfigGetter: e.DomainConfigGetter, |
There was a problem hiding this comment.
I'm concerned that this is now bleeding CLD internals (domains) into an environment which doesn't need to know about this.
Think about a case like devenv where they may not actually have domains.
There was a problem hiding this comment.
I think this may be more of a naming problem though.
If we remove Domain then I understand where this would work
There was a problem hiding this comment.
yeah i think domain may be the wrong name for it as the name couples the domain concept into cld
There was a problem hiding this comment.
when its purpose is just to be a generic getter for configs
2 participants
Add an Environment-level DomainConfigGetter interface with an os.Getenv-backed implementation, and cover default wiring plus getter behavior with focused deployment tests.