Skip to content

feat: add signer methods to mcms adapters#844

Merged
gustavogama-cll merged 2 commits intomainfrom
ggama/feat/add-signer-methods-mcms-adapters
Mar 11, 2026
Merged

feat: add signer methods to mcms adapters#844
gustavogama-cll merged 2 commits intomainfrom
ggama/feat/add-signer-methods-mcms-adapters

Conversation

@gustavogama-cll
Copy link
Contributor

@gustavogama-cll gustavogama-cll commented Mar 10, 2026

This PR adds additional methods to MCMS's chain adapters, exposing the chain's signer object (aka, the deployer key) for most supported chain families.

It introduces a small breaking change (the original Sui method was split into SuiClient and SuiSigner), but this is already addressed in a PR to the only client of this API.


OPT-463

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2026

🦋 Changeset detected

Latest commit: d4908fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
chainlink-deployments-framework Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gustavogama-cll gustavogama-cll force-pushed the ggama/feat/add-signer-methods-mcms-adapters branch 3 times, most recently from 26fff7e to f3448e9 Compare March 10, 2026 21:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the MCMS chain access adapter layer to expose per-chain signer/deployer keys across supported chain families, aligning the framework with new MCMS adapter expectations and updating the mcms dependency accordingly.

Changes:

  • Add signer accessor methods to ChainAccessAdapter and split Sui access into separate SuiClient and SuiSigner methods (breaking change).
  • Update unit tests to validate new client/signer accessors for most chains.
  • Add mockery config and generated mocks for Aptos/Sui/TON interfaces; bump github.com/smartcontractkit/mcms to v0.37.0.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
go.mod Bumps github.com/smartcontractkit/mcms to v0.37.0.
go.sum Updates checksum entries for the mcms version bump.
chain/mcms/adapters/chain_access.go Adds signer getters (EVM/Solana/Aptos/Sui/TON/Stellar) and changes Sui client accessor signature.
chain/mcms/adapters/chain_access_test.go Expands tests to cover new accessors and updated Sui API shape.
chain/aptos/mocks/aptos_rpc_client.go Adds generated Aptos RPC client mock.
chain/aptos/mocks/transaction_signer.go Adds generated Aptos transaction signer mock.
chain/ton/mocks/api_client_wrapped.go Adds generated TON API client wrapper mock.
.mockery.yml Configures mockery generation for Aptos/Sui/TON interfaces.
.changeset/mean-views-punch.md Adds a changeset entry for the release.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@gustavogama-cll gustavogama-cll marked this pull request as ready for review March 10, 2026 23:22
@gustavogama-cll gustavogama-cll requested a review from a team as a code owner March 10, 2026 23:22
Copilot AI review requested due to automatic review settings March 10, 2026 23:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

chain/mcms/adapters/chain_access_test.go:156

  • The adapter adds a StellarSigner accessor, but this test suite doesn't assert its behavior (either for unknown selectors or for a known Stellar chain). Please add assertions for a.StellarSigner(...) similar to the other signer accessors so regressions are caught.
	gotStellar, ok := a.StellarClient(stellarSel)
	require.True(t, ok)
	require.Nil(t, gotStellar)


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cl-sonarqube-production
Copy link

@gustavogama-cll gustavogama-cll added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit 97cef23 Mar 11, 2026
25 checks passed
@gustavogama-cll gustavogama-cll deleted the ggama/feat/add-signer-methods-mcms-adapters branch March 11, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants