DF-23700 fix sanitization and harmonize metrics with caller's#106
Open
DF-23700 fix sanitization and harmonize metrics with caller's#106
Conversation
vlfig
force-pushed
the
fix-rpcUrl-sanitization
branch
from
039edce to
446045d
Compare
📊 API Diff Results
|
dhaidashenko
previously approved these changes
May 6, 2026
Harmonize labels and values across latency and error/success metrics. rpcDomain, not rpcUrl callName, not rpcCallName Caller passes hostname, not full URL but keeping sanitization for future-proofing.
Contributor
Author
|
Sorry @dhaidashenko , I realised there were a couple changes more. Trivial stuff though. |
vlfig
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix rpcUrl sanitization to deal with absent protocol, just the hostname.
Harmonize labels and values across latency and error/success metrics.
Requires Dependencies
Resolves Dependencies