feat: Add Streams LLO NoDAG Trigger capability #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cre/capabilities/streams/v1/trigger.proto - Define Config message (stream_ids, max_frequency_ms) - Define Report message matching OCRTriggerEvent - Define OCRSignature message for attributed signatures - Add Streams service with Trigger RPC - Capability ID: streams-trigger@2.0.0 - Support for Data Feeds migration to CRE NoDAG architecture
🦋 Changeset detectedLatest commit: 53b7b56 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 cawthorne, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
feat: Add Streams LLO NoDAG Trigger capabilityDescription:
Summary
Add proto definition for the Streams LLO NoDAG Trigger capability to support Asset DON → CRE DON-to-DON communication for Data Feeds workflows.
This proto exposes the existing LLO transmitter through the NoDAG Capability API, enabling workflow-driven consumption of OCR reports from the LLO plugin.
What Changed
New Proto:
cre/capabilities/streams/v1/trigger.protoConfig message: Defines trigger configuration
stream_ids: uint32 array identifying LLO feeds to subscribe tomax_frequency_ms: Per-subscriber throttling interval (must be multiple of 1000ms)Report message: OCR trigger event payload
config_digest: OCR configuration digestseq_nr: Report sequence numberreport: Raw OCR report bytessigs: Array of attributed signatures (OCRSignature)OCRSignature message: Attributed onchain signature
signer: Signer indexsignature: Signature bytesStreams service: NoDAG trigger service
TriggerRPC: Streaming RPC that emits Report messagesstreams-trigger@2.0.0MODE_DONWhy These Changes
Migration to NoDAG: This capability is required to migrate Keystone Data Feeds workflows from the legacy DAG architecture to the new CRE NoDAG architecture.
Matches LLO Transmitter Output: The proto structure matches the existing
OCRTriggerEventthat the LLO transmitter emits, ensuring seamless integration without changes to the LLO plugin.Enables Workflow-Driven Feeds: CRE workflows can now subscribe to LLO reports via the trigger API, enabling:
Design Doc
See comprehensive design document: LLO CRE DON-to-DON Trigger Design
Related PRs
Breaking Changes
None. This is a new capability with no impact on existing protos.
Note on CI Failures: The
buf breakingchecks are expected to fail for new proto definitions. These failures are normal and will be reviewed/approved by maintainers.Checklist
streams-trigger@2.0.0)MODE_DONfor DON-to-DON communicationTesting