Skip to content

Conversation

@skudasov
Copy link
Contributor

@skudasov skudasov commented Jan 16, 2026


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes introduce a new documentation section on detecting resource leaks, along with relevant code to support this detection. This includes a utility for Chainlink node leak detection, a Dockerfile, and a Justfile for building and running a resource hogging application to test leak detection. Additionally, the pull request includes updates to the MeasureDelta function for improved leak measurement and modifications to the leak detection configuration for Chainlink nodes. These changes aim to enhance the framework's ability to detect and debug potential resource leaks in testing environments.

What

  • book/src/SUMMARY.md
    • Added a new section titled "Detecting Resource Leaks" to the documentation. This update aims to provide users with guidance on how to detect resource leaks within their testing framework.
  • book/src/framework/resource_leaks.md
    • Created a new markdown file detailing how to detect resource leaks, including examples on CL nodes leak detection and custom resource assertion. This document serves as a guide for developers to identify and address resource leaks in their tests.
  • framework/.changeset/v0.13.2.md
    • Introduced changes to the changelog, mentioning the addition of pprof dumps download and an update to the CPU query for generalization and improvement. This change log update communicates the enhancements made in version v0.13.2 of the framework.
  • framework/leak/cmd/Dockerfile
    • Added a Dockerfile for building a container that can be used to simulate resource hogging. This tool is useful for testing the framework's ability to detect resource leaks.
  • framework/leak/cmd/Justfile
    • Included a Justfile with commands to build and run the resource hogging application, facilitating easy testing of the leak detection capabilities.
  • framework/leak/cmd/go.mod
    • Created a Go module file for the resource hogging application, defining its dependencies and module path.
  • framework/leak/cmd/main.go
    • Implemented the main logic for the resource hogging application, which can generate CPU and memory load for testing purposes.
  • framework/leak/detector.go
    • Modified the MeasureDelta function for improved accuracy in measuring resource leaks. This change enhances the reliability of leak detection metrics.
  • framework/leak/detector_cl_node.go
    • Updated the configuration for Chainlink node leak detection, refining the queries used to measure resource consumption. This adjustment allows for more precise tracking of potential leaks.
  • framework/leak/detector_hog_test.go
    • Added a test file for the resource hogging application, enabling developers to verify the functionality of their leak detection setup.
  • framework/leak/detector_test.go
    • Updated unit tests to reflect changes in the MeasureDelta function, ensuring the modifications do not break existing functionality.

@skudasov skudasov requested a review from a team as a code owner January 16, 2026 17:40
@github-actions
Copy link

👋 skudasov, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@skudasov skudasov requested a review from kdihalas January 16, 2026 17:44
kdihalas
kdihalas previously approved these changes Jan 16, 2026
@skudasov skudasov changed the title Resource leak pprof and improvements Improve queries and add docs for leak detector Jan 16, 2026
@skudasov skudasov merged commit 72a0dad into main Jan 16, 2026
73 of 75 checks passed
@skudasov skudasov deleted the resource-leak-pprof-and-improvements branch January 16, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants