-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Using MaxGasPrice from txRequest #20763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the EVM service to use the MaxGasPrice parameter from transaction requests when submitting transactions. This allows callers to specify a maximum gas price limit for their transactions, which is then passed through to the underlying transaction manager.
Changes:
- Updated dependency versions for
chainlink-evmandchainlink-framework/chainspackages - Added logic to extract and use
MaxGasPricefrom transaction requests in the EVM service
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updated chainlink-evm and chainlink-framework/chains dependencies to newer versions |
| core/services/relay/evm/evm_service.go | Added extraction and usage of MaxGasPrice from txRequest.GasConfig when submitting transactions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I see you updated files related to
|
|




https://smartcontract-it.atlassian.net/browse/PLEX-1522
Depends on:
smartcontractkit/chainlink-protos#256
smartcontractkit/chainlink-common#1764
smartcontractkit/chainlink-framework#80
smartcontractkit/chainlink-evm#323