fix: support MultiHeaders in DirectHTTPAction fake#21406
Merged
Conversation
The fake HTTP action only read the deprecated Headers field, ignoring MultiHeaders. This caused simulation tests to fail when workflows use the new MultiHeaders proto field. Matches the production behavior in capabilities/http_action/common/proxy.go by preferring MultiHeaders and falling back to Headers.
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
prashantkumar1982
previously approved these changes
Mar 4, 2026
MStreet3
approved these changes
Mar 5, 2026
|
agparadiso
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DirectHTTPActionfake only iterated overinput.GetHeaders()(deprecated), ignoringinput.GetMultiHeaders()MultiHeadersproto field had empty headers during simulation, causing e2e test failures (e.g.fix: adds MultiHeaders to http package cre-cli#298)
capabilities/http_action/common/proxy.go: preferMultiHeaders, fall back to deprecatedHeadersTest plan