test: add missing pack for grant role timelock#39
Merged
ajaskolski merged 2 commits intomainfrom May 6, 2026
Merged
Conversation
product-security-plaid-production
Bot
requested a review
from DimitriosNaikopoulos
ajaskolski
changed the title
ajaskolski
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Go test suite to validate GrantRoleTimelockSolana.VerifyPreconditions, ensuring expected failures for misconfigured environments/configs and confirming valid configurations pass.
Changes:
- Introduces table-driven tests for successful precondition validation (including
MCMS: nil). - Adds negative test cases for: no Solana chains, missing chain selector in environment, invalid MCMS action, and incomplete MCMS/timelock address fixtures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChrisAmora
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.