PRIV-372: Add --confidential/--secret flags to workflow simulate#306
Open
PRIV-372: Add --confidential/--secret flags to workflow simulate#306
Conversation
In production, confidential workflows only get access to secrets declared at deploy time. The simulator now enforces the same restriction so developers catch mismatches before deploying. PRIV-372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--confidentialand--secretflags tocre workflow simulate, mirroring the deploy command--secretrequires--confidential,--confidentialrequires at least one--secret, empty keys are rejectedChanged files
cmd/workflow/simulate/simulate.go- flags, Inputs fields, validation, filtering call in Executecmd/workflow/simulate/secrets.go-FilterSecretsByAllowedKeys,secretKeyshelpercmd/workflow/simulate/secrets_test.go- 5 filter tests + secretKeys testcmd/workflow/simulate/simulate_test.go- 3 validation tests