OPDATA-5659 Improve PoR EA messaging for schedule-based data suppression#4689
Open
Subarna-Singh wants to merge 3 commits intomainfrom
Open
OPDATA-5659 Improve PoR EA messaging for schedule-based data suppression#4689Subarna-Singh wants to merge 3 commits intomainfrom
Subarna-Singh wants to merge 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: c942c53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dskloetc
reviewed
Mar 2, 2026
| `Current: ${currentUTC.toISOString()}, ` + | ||
| `Window: [${startUTC.toISOString()} - ${endUTC.toISOString()}], ` + | ||
| `NextWindowStart: ${nextWindowStart.toISOString()}` | ||
| Logger.info(message) |
Contributor
There was a problem hiding this comment.
This will log every 10 seconds while the window is closed, right? Isn't that a lot of log spam?
Contributor
Author
There was a problem hiding this comment.
It is. I can remove the logging and just it in the error message.
| `Window: [${startUTC.toISOString()} - ${endUTC.toISOString()}], ` + | ||
| `NextWindowStart: ${nextWindowStart.toISOString()}` | ||
| Logger.info(message) | ||
| throw new Error(message) |
Contributor
There was a problem hiding this comment.
Does this cause a 400 or 500 error? Do we want to use an AdapterError and decide explicitly what status code to return?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #OPDATA-5659
Description
https://smartcontract-it.atlassian.net/browse/OPDATA-5659
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.