Skip to content

Additional metrics#4690

Merged
denis-chernov-smartcontract merged 3 commits intostreams-adaptersfrom
DS-1455/additional-metrics
Mar 3, 2026
Merged

Additional metrics#4690
denis-chernov-smartcontract merged 3 commits intostreams-adaptersfrom
DS-1455/additional-metrics

Conversation

@denis-chernov-smartcontract
Copy link

@denis-chernov-smartcontract denis-chernov-smartcontract commented Mar 2, 2026 •
edited
Loading

Closes #DS 1455

Description

New metrics: cache_data_get_count, and http_request_duration_seconds
http_requests_total is now backward compatible
......

Changes

  • High level
  • changes that
  • you made

Steps to Test

  1. Steps
  2. to
  3. test

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 69c385a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ro-tex
ro-tex approved these changes Mar 3, 2026
View reviewed changes
packages/streams-adapter/middleware/metrics.go
// Record the metric
m.RecordHTTPRequest(method, statusCode, retry, requestType, assetPair, providerStatusCode)
m.RecordHTTPRequest(method, statusCode, retry, requestType, isCacheWarming, feedID, providerStatusCode)
m.RecordHTTPRequestDuration(time.Since(start).Seconds())
Copy link

@ro-tex ro-tex Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seconds sounds a bit coarse. How about millis?

Copy link
Author

@denis-chernov-smartcontract denis-chernov-smartcontract Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make this metric backward compatible
https://github.com/smartcontractkit/external-adapters-js/blob/main/packages/core/bootstrap/src/lib/metrics/index.ts

@denis-chernov-smartcontract denis-chernov-smartcontract merged commit 3326469 into streams-adapters Mar 3, 2026
@denis-chernov-smartcontract denis-chernov-smartcontract deleted the DS-1455/additional-metrics branch March 3, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ro-tex ro-tex ro-tex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@denis-chernov-smartcontract @ro-tex