feat(canton): Implement timelock interfaces#636
Conversation
|
product-security-plaid-production
bot
requested a review
from gustavogama-cll
| PreOpCount uint64 `json:"preOpCount"` | ||
| PostOpCount uint64 `json:"postOpCount"` |
There was a problem hiding this comment.
Do we use these for anything @RodrigoAD?
| // suite.Run(t, new(cantone2e.MCMSExecutorTestSuite)) | ||
| suite.Run(t, new(cantone2e.TimelockInspectionTestSuite)) | ||
| suite.Run(t, new(cantone2e.TimelockProposalTestSuite)) | ||
| } |
There was a problem hiding this comment.
TODO: add canceler tests
| TargetInstanceId: targetInstanceId, | ||
| FunctionName: functionName, | ||
| OperationData: opDataHex, | ||
| TargetCid: mcmAddress, |
There was a problem hiding this comment.
I think this behavior of setting targetCids is going to fail, IMO the additionalFields should contain the instanceAddresses, not the contractIDs.
Imagine we execute two operations to the same contract in the same proposal, what is going to happen?
The problem with that is that both mcms.ExecuteOp and mcms.ExecuteScheduledBatch calls for CIDs, which are used onChain, how can we batch, for instance, two sequential calls to counter.Increment then?
1 participant
Summary
Implements all the interfaces for timelock on Canton.
This PR is based on #624
Major differences:
setRoot/schedule[each op]/executeBatch)sdk/canton/inspector.go