Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/ClientBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const BaseUrlSender = require("./BaseUrlSender");
const AgentSender = require("./AgentSender");
const StaticCredentials = require("./StaticCredentials");
const SharedCredentials = require("./SharedCredentials");
const BasicAuthCredentials = require("./BasicAuthCredentials");
const CustomHeaderSender = require("./CustomHeaderSender");
const StatusCodeSender = require("./StatusCodeSender");
const LicenseSender = require("./LicenseSender");
Expand Down Expand Up @@ -54,7 +55,7 @@ class ClientBuilder {
this.customQueries = new Map();

function credentialsProvided() {
return signer instanceof StaticCredentials || signer instanceof SharedCredentials;
return signer instanceof StaticCredentials || signer instanceof SharedCredentials || signer instanceof BasicAuthCredentials;
}
}

Expand Down
1 change: 1 addition & 0 deletions src/SigningSender.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Request, Response, Sender } from "./types.js";
import SharedCredentials from "./SharedCredentials.js";
import BasicAuthCredentials from "./BasicAuthCredentials.js";
import { UnprocessableEntityError } from "./Errors.js";

interface Signer {
Expand Down
22 changes: 22 additions & 0 deletions tests/test_SigningSender.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import Response from "../src/Response.js";
import SigningSender from "../src/SigningSender.js";
import StaticCredentials from "../src/StaticCredentials.js";
import SharedCredentials from "../src/SharedCredentials.js";
import BasicAuthCredentials from "../src/BasicAuthCredentials.js";
import { UnprocessableEntityError } from "../src/Errors";

describe("A signing sender", function () {
Expand Down Expand Up @@ -45,6 +46,16 @@ describe("A signing sender", function () {
);
});

it("signs a request with basic auth credentials.", function () {
const basicAuthCredentials = new BasicAuthCredentials(mockAuthId, mockAuthToken);
const signingSender = new SigningSender(mockSender, basicAuthCredentials);

signingSender.send(request);

expect("Authorization" in request.headers).to.equal(true);
expect((request.headers as Record<string, string>)["Authorization"]).to.include("Basic ");
});

it("errors if signing a POST request with shared credentials.", function () {
const sharedCredentials = new SharedCredentials(mockAuthId, mockHostName);
const signingSender = new SigningSender(mockSender, sharedCredentials);
Expand All @@ -55,4 +66,15 @@ describe("A signing sender", function () {

expect(() => signingSender.send(request)).to.throw(UnprocessableEntityError);
});

it("does not error if signing a POST request with basic auth credentials.", function () {
const basicAuthCredentials = new BasicAuthCredentials(mockAuthId, mockAuthToken);
const signingSender = new SigningSender(mockSender, basicAuthCredentials);
const mockRequestPayload = {
foo: "bar",
};
request.payload = mockRequestPayload;

expect(() => signingSender.send(request)).to.not.throw();
});
});
Loading