[WIP] Work on KartObjectProxy (and related)#301
Merged
em-eight merged 6 commits intosnailspeed3:masterfrom Jul 15, 2025
Merged
Conversation
Report for RMCP01 (6eed2ce - c681e7e)📈 Matched code: 5.69% (+0.01%, +416 bytes) ✅ 22 new matches:
📈 1 improvements in unmatched functions:
📉 190 regressions in unmatched functions:
...and 160 more regressions in unmatched functions |
em-eight
reviewed
Jul 12, 2025
src/kart/KartObjectProxy.cpp
Outdated
| dynamics = kartDynamics(); | ||
| dynamics->pos.x = x; | ||
| dynamics->pos.y = y; | ||
| dynamics->pos.z = z; |
Contributor
There was a problem hiding this comment.
Move definitions to declarations if you can maintain matching
src/kart/KartObjectProxy.cpp
Outdated
| dynamics->mainRot.x = x; | ||
| dynamics->mainRot.y = y; | ||
| dynamics->mainRot.z = z; | ||
| dynamics->mainRot.w = w; |
Contributor
There was a problem hiding this comment.
Move definitions to declarations if you can maintain matching
src/kart/KartSus.hpp
Outdated
|
|
||
| namespace Kart { | ||
| class KartSus { | ||
| class KartSusPhysics; |
Contributor
There was a problem hiding this comment.
indentation. Also would be good to leave an empty line between declarations
added 2 commits
July 12, 2025 12:10
em-eight
reviewed
Jul 13, 2025
src/kart/KartObjectProxy.cpp
Outdated
| dynamics->mainRot.z = z; | ||
| dynamics->mainRot.w = w; | ||
| void KartObjectProxy::setRot(const EGG::Quatf &rot) { | ||
| KartDynamics* dynamics =kartDynamics(); |
Contributor
There was a problem hiding this comment.
one more indentation hiccup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
working on the Kart objects