chore(language-server): integrate LS #6399

Team-Hammerhead · 2025-12-19T05:46:16Z

Changes since last integration of Language Server

commit b70c950dda41bbb323f80ef5e357a773135c9813
Author: Bastian Doetsch <bastian.doetsch@snyk.io>
Date:   Fri Jan 2 16:06:04 2026 +0100

    fix: never send progress with empty value (#1108)

M	application/server/notification.go
M	internal/progress/progress.go

commit eda8024bd3c7ea0938e74e7016acdfe26fb3ce66
Author: Ben Durrans <Benjamin.Durrans@snyk.io>
Date:   Tue Dec 23 19:35:32 2025 +0000

    test: disable auto auth in 2 more tests (#1065)
    
    Following on from a3f87ec these two tests were missed as they have custom init params.
    
    Co-authored-by: Bastian Doetsch <bastian.doetsch@snyk.io>

M	application/server/inline_values_test.go
M	application/server/server_smoke_test.go

commit d74fa4af943f7bc6915cabfd554fbccedfcb95d5
Author: nick-y-snyk <nikita.yasnohorodskyi@snyk.io>
Date:   Tue Dec 23 18:34:22 2025 +0100

    IDE-1578: refactor: consolidate dirty tracking and auto-save (#1104)
    
    refactor: consolidate dirty tracking and auto-save into unified form state tracking
    
    Consolidates dirty-tracking.js and auto-save listener attachment into a single
    form-state-tracking.js module. Both dirty tracking and auto-save now share the
    same event listeners (blur/change), ensuring consistent coverage across all
    form interactions.
    
    Key changes:
    - Created form-state-tracking.js with consolidated blur-based event listeners
    - Removed duplicate listener attachment from auto-save.js and dirty-tracking.js
    - Both dirty tracking and auto-save now trigger together via triggerChangeHandlers()
    - Added skipTrigger parameter to folder-management.js to prevent auto-save during initialization
    - Dynamically created trusted folder inputs now get blur listeners attached
    - Auto-save gated by __IS_IDE_AUTOSAVE_ENABLED__ flag to prevent premature saves

M	docs/configuration-dialog.md
M	infrastructure/configuration/config_html.go
M	infrastructure/configuration/template/config.html
M	infrastructure/configuration/template/js/auto-save.js
D	infrastructure/configuration/template/js/dirty-tracking.js
M	infrastructure/configuration/template/js/folder-management.js
A	infrastructure/configuration/template/js/form-state-tracking.js
M	infrastructure/configuration/template/js/init.js
M	infrastructure/configuration/template/js/trusted-folders.js

commit 78a68d25a7efdf976d4c0f35e18c3053da61a710
Author: nick-y-snyk <nikita.yasnohorodskyi@snyk.io>
Date:   Fri Dec 19 17:19:16 2025 +0100

    feat: improve config dialog UI and validation (#1102)
    
    * feat: improve config dialog UI and validation
    
    - Rename "Pre/Post-Scan Only Reference Folder" to user-friendly "Run only in reference folder"
    - Move validation logic to validation.js for better separation of concerns
    - Add per-folder additional environment variables validation
    - Style "Add Folder" button to match authenticate button and align right
    - Add visual hierarchy with indentation for nested pre/post scan commands
    - Consolidate all validation initialization into single function
    - Remove legacy global additionalEnv field support
    
    * Update infrastructure/configuration/template/js/validation.js
    
    Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
    
    * Update infrastructure/configuration/template/js/validation.js
    
    Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

M	infrastructure/configuration/template/config.html
M	infrastructure/configuration/template/js/auto-save.js
M	infrastructure/configuration/template/js/init.js
M	infrastructure/configuration/template/js/validation.js
M	infrastructure/configuration/template/styles.css

commit 82d1e25c0da11614d07ab37127c61a7f72e9c17b
Author: nick-y-snyk <nikita.yasnohorodskyi@snyk.io>
Date:   Fri Dec 19 12:57:57 2025 +0100

    rollback: snyk product names (#1101)
    
    * rollback: snyk product names
    
    * Update infrastructure/configuration/template/js/form-data.js
    
    Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

M	infrastructure/code/code_test.go
M	infrastructure/code/issue_enhancer_test.go
M	infrastructure/configuration/template/config.html
M	infrastructure/configuration/template/js/form-data.js
M	internal/product/product.go

commit eeb8a8736e7cc9bcd40025e5d4af3335da329a02
Author: Bastian Doetsch <bastian.doetsch@snyk.io>
Date:   Fri Dec 19 11:07:15 2025 +0100

    fix(oss): respect add additional commands to `--all-projects` blacklist [IDE-1126] (#1098)
    
    * fix(oss): respect --all-sub-projects blacklist [IDE-1126]
    
    Add unit coverage ensuring --all-projects is not appended when --all-sub-projects is provided.
    Sync allProjectsParamBlacklist entries with Snyk CLI.
    
    * test(oss): cover allProjectsParamBlacklist [IDE-1126]
    
    Convert the blacklist regression check to a table-driven test covering all blacklisted flags.

M	infrastructure/oss/cli_scanner.go
M	infrastructure/oss/cli_scanner_test.go

commit d63b4b11f5111cc7b0782c3a1c6ceecfb86191f8
Author: Bastian Doetsch <bastian.doetsch@snyk.io>
Date:   Fri Dec 19 06:49:21 2025 +0100

    fix: Maven version highlighting in unified test API flow [IDE-1620] (#1095)
    
    * chore: remove changelog requirement from windsurf rules
    
    * fix(maven): align pom.xml ranges with version [IDE-1620]
    
    Dependency diagnostics/CodeLens should point at the <version> value.
    
    - Normalize CRLF to keep offsets stable
    - Fix Maven XML unmarshalling for groupId
    - Prefer version tag range (fallback to artifactId when missing)
    - Update range-finder and parser tests
    
    * fix: use the right path in unified_converter.go
    
    * fix: make git checkout cleanup synchronous to prevent flaky tests [IDE-1620]
    
    The gitCheckoutHandler.CleanupFunc() was being called as a goroutine,
    which meant the cleanup (removing temp directories) ran asynchronously.
    When tests finished and Go's testing framework tried to clean up
    t.TempDir(), the async cleanup goroutine could still be holding file
    handles, causing 'file in use' errors on Windows.
    
    This change makes the cleanup synchronous by removing the 'go' keyword,
    ensuring all file handles are released before the Scan function returns.
    
    * refactor: simplify whitespace trimming in Maven parser [IDE-1620]
    
    Simplified the logic for trimming whitespace and adjusting offsets
    in addNewNodeTo function as suggested by code review. The new approach
    calculates leading whitespace and trimmed value length more directly.

M	.windsurfrules
M	ast/maven/parser.go
M	ast/maven/parser_test.go
M	domain/snyk/scanner/scanner.go
M	infrastructure/oss/maven_range_finder_test.go
M	infrastructure/oss/unified_converter.go

commit 6748dd46e694a40f6bb22697ee5b923938c4ba6e
Author: Bastian Doetsch <bastian.doetsch@snyk.io>
Date:   Fri Dec 19 06:27:17 2025 +0100

    fix: persist risk score threshold in configuration dialog [IDE-1629] (#1097)
    
    - Add RiskScoreThreshold to populatePointerFields in configuration_command.go
      to read the saved value when re-opening the config dialog
    - Fix template nil check in config.html to properly render value 0
    
    The primary issue was that RiskScoreThreshold was never populated from
    the stored config when constructing settings for the HTML renderer.
    The secondary issue was that the Go template used a truthy check which
    would fail for value 0.

M	domain/ide/command/configuration_command.go
M	infrastructure/configuration/template/config.html

commit 99543a87fec555f7ee5f76db552a0fab74a35d44
Author: nick-y-snyk <nikita.yasnohorodskyi@snyk.io>
Date:   Thu Dec 18 18:30:12 2025 +0100

    feat: add IE11 support for configuration dialog [IDE-1458] (#1092)
    
    * feat: add IE11 support for configuration dialog [IDE-1458]
    
    - Add IE11 custom properties polyfill for CSS variable support
    - Embed Bootstrap 4 and jQuery locally instead of using CDN
    - Update data attributes from Bootstrap 5 to Bootstrap 4 syntax (data-bs-* to data-*)
    - Update CSP to remove external CDN references
    - Ensure configuration dialog works in legacy IE11 browser
    
    * fix: tests
    
    * feat: add save status notification and drop filepicker for now
    
    * fix: trusted folders serialization
    
    * feat: baseUrl and commandConfig update handling
    
    * feat: move addtional env to folder level
    
    * fix: scanCommandConfig html handling
    
    * fix: use full product names in scanCommandConfig template
    
    Updates HTML template and form handling to use full product names
    ("Snyk Open Source", "Snyk Code", "Snyk IaC") instead of short forms
    ("oss", "code", "iac") for scan command configuration fields.
    
    - Simplifies getScanConfig helper by removing product name mapping logic
    - Updates template to pass full product names as strings
    - Updates smoke test to initialize workspace with folder configs
    - Updates documentation with correct field naming convention
    
    This ensures consistent product naming throughout the configuration
    dialog and simplifies the template rendering logic.

M	application/server/configuration.go
M	application/server/configuration_smoke_test.go
M	docs/configuration-dialog.md
M	domain/ide/command/configuration_command.go
M	infrastructure/code/code_test.go
M	infrastructure/code/issue_enhancer_test.go
M	infrastructure/configuration/config_html.go
M	infrastructure/configuration/config_html_test.go
M	infrastructure/configuration/template/config.html
M	infrastructure/configuration/template/js/auto-save.js
M	infrastructure/configuration/template/js/folder-management.js
M	infrastructure/configuration/template/js/form-data.js
A	infrastructure/configuration/template/js/ie11CustomProperties.js
M	infrastructure/configuration/template/js/init.js
M	infrastructure/configuration/template/styles.css
A	infrastructure/configuration/template/vendor/bootstrap.bundle.min.js
A	infrastructure/configuration/template/vendor/bootstrap.min.css
A	infrastructure/configuration/template/vendor/jquery.slim.min.js
M	internal/product/product.go
M	internal/types/lsp.go

github-actions · 2025-12-19T05:47:19Z

	Warnings
⚠️	"chore: automatic integration of language server b70c950dda41bbb323f80ef5e357a773135c9813" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 99f8fc6

…ef5e357a773135c9813

Team-Hammerhead requested review from a team as code owners December 19, 2025 05:46

Team-Hammerhead enabled auto-merge December 19, 2025 05:46

team-ide-user force-pushed the chore/automatic-upgrade-of-ls branch 3 times, most recently from 0b97ee4 to e1704c8 Compare December 19, 2025 12:14

PeterSchafer approved these changes Dec 19, 2025

View reviewed changes

team-ide-user force-pushed the chore/automatic-upgrade-of-ls branch 3 times, most recently from c8671f8 to bb6f295 Compare December 23, 2025 19:53

chore: automatic integration of language server b70c950dda41bbb323f80…

99f8fc6

…ef5e357a773135c9813

team-ide-user force-pushed the chore/automatic-upgrade-of-ls branch from bb6f295 to 99f8fc6 Compare January 2, 2026 15:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(language-server): integrate LS #6399

chore(language-server): integrate LS #6399

Team-Hammerhead commented Dec 19, 2025 •

edited by atlassian bot

Loading

Uh oh!

github-actions bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore(language-server): integrate LS #6399

Are you sure you want to change the base?

chore(language-server): integrate LS #6399

Conversation

Team-Hammerhead commented Dec 19, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes since last integration of Language Server

Uh oh!

github-actions bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Team-Hammerhead commented Dec 19, 2025 •

edited by atlassian bot

Loading

github-actions bot commented Dec 19, 2025 •

edited

Loading