Remove unused argument from crypto_kx#36
Open
christianbundy wants to merge 1 commit intosodium-friends:masterfrom
Open
Remove unused argument from crypto_kx#36christianbundy wants to merge 1 commit intosodium-friends:masterfrom
christianbundy wants to merge 1 commit intosodium-friends:masterfrom
Conversation
Problem: randombytes_buf uses the size of the buffer as the number of bytes to output, so we don't need to add an argument about the number of bytes we want. Solution: Remove unused argument and use buffer size assertion to be sure that we're producing the correct number of random bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: randombytes_buf uses the size of the buffer as the number of
bytes to output, so we don't need to add an argument about the number of
bytes we want.
Solution: Remove unused argument and use buffer size assertion to be
sure that we're producing the correct number of random bytes.