Fix problem when crypto_aead detached passed null#39
Open
christianbundy wants to merge 1 commit intosodium-friends:masterfrom
Open
Fix problem when crypto_aead detached passed null#39christianbundy wants to merge 1 commit intosodium-friends:masterfrom
christianbundy wants to merge 1 commit intosodium-friends:masterfrom
Conversation
Problem: In two cases the `if (ad === null)` conditions are meant to call a `_detached` method but accidentally call the non-detached counterpart. Solution: Call the corresponding function so that detached methods always call detached encryption or decryption. See-also: sodium-friends#35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: In two cases the
if (ad === null)conditions are meant tocall a
_detachedmethod but accidentally call the non-detachedcounterpart.
Solution: Call the corresponding function so that detached methods
always call detached encryption or decryption.
See-also: #35