fix: Not sure why this is here, but it breaks my webpack build.#59
Open
okdistribute wants to merge 1 commit intosodium-friends:masterfrom
Open
fix: Not sure why this is here, but it breaks my webpack build.#59okdistribute wants to merge 1 commit intosodium-friends:masterfrom
okdistribute wants to merge 1 commit intosodium-friends:masterfrom
Conversation
|
I ran into the same issue and fixed it while keeping support for nodejs. See PR #67 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't have a whole lot of time to investigate this today, since I'm just making a proof of concept prototype, but I became curious to know why this piece of code is here ?
Is there another way to do this that is less hacky?
EDIT: I don't actually think this is necessary anymore if you use sodium-universal for libraries that need isomorphic support.