Skip to content

WIP Fixing Noise handshake issue#71

Open
fix wants to merge 5 commits intosodium-friends:masterfrom
vaultys:master
Open

WIP Fixing Noise handshake issue#71
fix wants to merge 5 commits intosodium-friends:masterfrom
vaultys:master

Conversation

@fix
Copy link

@fix fix commented Oct 8, 2025

I can confirm i managed to fix holepunchto/hypercore#452 namely this error.

Noise handshake failed
    at NoiseSecretStream._onhandshakert (bundle.js?t=1699883966724:403:33)
    at NoiseSecretStream._open (bundle.js?t=1699883966724:451:32)
    at WritableState.updateNonPrimary (bundle.js?t=1699883966724:21823:14)
    at WritableState.update (bundle.js?t=1699883966724:21798:72)
    at WritableState.updateWriteNT (bundle.js?t=1699883966724:22147:10)

The PR is self explanatory.

fix added 5 commits October 8, 2025 15:38
fix for missing crypto_scalarmult_ed25519_BYTES exportation
added crypto_scalarmult_ed25519_noclamp
@fix fix changed the title Fixing Noise handshake issue WIP Fixing Noise handshake issue Oct 9, 2025
@fix
Copy link
Author

fix commented Oct 9, 2025

still WIP, i discovered there was a missing implementation crypto_scalarmult_ed25519_noclamp that is added now

however somehow debugging the code, it sounds the noise handshake fails now because of verification fail here, where the computed mac is not the one expected

const ret = crypto_verify_16(computed_mac, 0, mac, 0)

not sure if this is related...

@fix
Copy link
Author

fix commented Oct 9, 2025

ok bummer, i used curve25519 instead of ed25519, working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Browser support

1 participant