Open
Conversation
fix for missing crypto_scalarmult_ed25519_BYTES exportation
added crypto_scalarmult_ed25519_noclamp
Author
|
still WIP, i discovered there was a missing implementation crypto_scalarmult_ed25519_noclamp that is added now however somehow debugging the code, it sounds the noise handshake fails now because of verification fail here, where the computed mac is not the one expected sodium-javascript/crypto_aead.js Line 129 in f19e6c8 not sure if this is related... |
Author
|
ok bummer, i used curve25519 instead of ed25519, working on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can confirm i managed to fix holepunchto/hypercore#452 namely this error.
The PR is self explanatory.