Skip to content

[all] Virtual inheritance of SingleStateAccessor#5819

Merged
th-skam merged 3 commits into
sofa-framework:masterfrom
alxbilger:singlestateaccessorvirtual
Dec 12, 2025
Merged

[all] Virtual inheritance of SingleStateAccessor#5819
th-skam merged 3 commits into
sofa-framework:masterfrom
alxbilger:singlestateaccessorvirtual

Conversation

@alxbilger
Copy link
Copy Markdown
Contributor

@alxbilger alxbilger commented Dec 10, 2025

This is to support multiple inheritance when two parents derive from SingleStateAccessor.

[ci-depends-on https://github.com/sofa-framework/SofaSphFluid/pull/18]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Dec 10, 2025
@alxbilger alxbilger force-pushed the singlestateaccessorvirtual branch from dc33461 to 88c9a0c Compare December 10, 2025 15:12
@bakpaul bakpaul added this to the v26.06 milestone Dec 11, 2025
@alxbilger alxbilger force-pushed the singlestateaccessorvirtual branch from 88c9a0c to e04de87 Compare December 11, 2025 13:35
@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Dec 12, 2025

[ci-depends-on] detected during build #4.

All dependencies are merged/closed. Congrats! 👍

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Dec 12, 2025

[ci-depends-on] detected during build #5.

All dependencies are merged/closed. Congrats! 👍

@th-skam th-skam merged commit 5fdc442 into sofa-framework:master Dec 12, 2025
9 of 13 checks passed
@th-skam th-skam added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 12, 2025
@hugtalbot hugtalbot modified the milestones: v26.06, v25.12 Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants